Jacob/zmk
1
0
Fork 0
forked from kofal.net/zmk
Code Pull Requests Activity

fix(combos): Fix stuck keys when pressing long combos.

Browse Source 
To properly retrigger hold-taps when a combo is not activated, some
position down events are reraised instead of released. The corresponding
position up events were never reraised, causing a potential stuck key.
This commit is contained in:
Okke Formsma
2021-02-27 22:34:15 +01:00
committed by Pete Johanson
parent 8ebe0cd0c8
commit 0df7110058
16 changed files with 82 additions and 46 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
app/tests/combo/combos-and-holdtaps-0/events.patterns
View File

@@ -1,2 +1 @@
s/.*hid_listener_keycode_//p
s/.*combo//p

3
app/tests/combo/combos-and-holdtaps-1/events.patterns
View File

@@ -1,2 +1 @@
s/.*hid_listener_keycode_//p
s/.*combo//p
s/.*hid_listener_keycode_//p

3
app/tests/combo/combos-and-holdtaps-2/events.patterns
View File

@@ -1,2 +1 @@
s/.*hid_listener_keycode_//p
s/.*combo//p
s/.*hid_listener_keycode_//p

3
app/tests/combo/layer-filter-0/events.patterns
View File

@@ -1,2 +1 @@
s/.*hid_listener_keycode_//p
s/.*combo//p
s/.*hid_listener_keycode_//p

3
app/tests/combo/layer-filter-1/events.patterns
View File

@@ -1,2 +1 @@
s/.*hid_listener_keycode_//p
s/.*combo//p
s/.*hid_listener_keycode_//p

3
app/tests/combo/overlapping-combos-0/events.patterns
View File

@@ -1,2 +1 @@
s/.*hid_listener_keycode_//p
s/.*combo//p
s/.*hid_listener_keycode_//p

3
app/tests/combo/overlapping-combos-1/events.patterns
View File

@@ -1,2 +1 @@
s/.*hid_listener_keycode_//p
s/.*combo//p
s/.*hid_listener_keycode_//p

3
app/tests/combo/overlapping-combos-2/events.patterns
View File

@@ -1,2 +1 @@
s/.*hid_listener_keycode_//p
s/.*combo//p
s/.*hid_listener_keycode_//p

3
app/tests/combo/overlapping-combos-3/events.patterns
View File

@@ -1,2 +1 @@
s/.*hid_listener_keycode_//p
s/.*combo//p
s/.*hid_listener_keycode_//p

1
app/tests/combo/press-release-long-combo/events.patterns Normal file
View File

@@ -0,0 +1 @@
s/.*hid_listener_keycode_//p

4
app/tests/combo/press-release-long-combo/keycode_events.snapshot Normal file
View File

@@ -0,0 +1,4 @@
pressed: usage_page 0x07 keycode 0x07 implicit_mods 0x00 explicit_mods 0x00
pressed: usage_page 0x07 keycode 0x05 implicit_mods 0x00 explicit_mods 0x00
released: usage_page 0x07 keycode 0x05 implicit_mods 0x00 explicit_mods 0x00
released: usage_page 0x07 keycode 0x07 implicit_mods 0x00 explicit_mods 0x00

35
app/tests/combo/press-release-long-combo/native_posix.keymap Normal file
View File

@@ -0,0 +1,35 @@
#include <dt-bindings/zmk/keys.h>
#include <behaviors.dtsi>
#include <dt-bindings/zmk/kscan-mock.h>
/ {
combos {
compatible = "zmk,combos";
combo_one {
timeout-ms = <80>;
key-positions = <0 1 2 3>;
bindings = <&kp Z>;
};
};
keymap {
compatible = "zmk,keymap";
label ="Default keymap";
default_layer {
bindings = <
&kp A &kp B
&kp C &kp D
>;
};
};
};
&kscan {
events = <
ZMK_MOCK_PRESS(1,1,10)
ZMK_MOCK_PRESS(0,1,10)
ZMK_MOCK_RELEASE(0,1,100)
ZMK_MOCK_RELEASE(1,1,100)
>;
};

3
app/tests/combo/press1-press2-release1-release2/events.patterns
View File

@@ -1,2 +1 @@
s/.*hid_listener_keycode_//p
s/.*combo/combo/p
s/.*hid_listener_keycode_//p

1
app/tests/combo/press1-press2-release2-release1/events.patterns
View File

@@ -1,2 +1 @@
s/.*hid_listener_keycode_//p
s/.*combo/combo/p

3
app/tests/combo/press1-release1-press2-release2/events.patterns
View File

@@ -1,2 +1 @@
s/.*hid_listener_keycode_//p
s/.*combo/combo/p
s/.*hid_listener_keycode_//p