initial implementation for modifiers

https://github.com/zmkfirmware/zmk/issues/86
2020-09-02 22:30:09 +02:00
parent a9e729b427
commit 4f258efbf1
77 changed files with 597 additions and 229 deletions
--- a/app/tests/hold-tap/balanced/1-dn-up/keycode_events.snapshot
+++ b/app/tests/hold-tap/balanced/1-dn-up/keycode_events.snapshot
@@ -1,5 +1,5 @@
 ht_binding_pressed: 0 new undecided hold_tap
 ht_decide: 0 decided tap (balanced event 0)
-kp_pressed: usage_page 0x07 keycode 0x09
-kp_released: usage_page 0x07 keycode 0x09
+kp_pressed: usage_page 0x07 keycode 0x09 mods 0x00
+kp_released: usage_page 0x07 keycode 0x09 mods 0x00
 ht_binding_released: 0 cleaning up hold-tap
--- a/app/tests/hold-tap/balanced/2-dn-timer-up/keycode_events.snapshot
+++ b/app/tests/hold-tap/balanced/2-dn-timer-up/keycode_events.snapshot
@@ -1,5 +1,5 @@
 ht_binding_pressed: 0 new undecided hold_tap
 ht_decide: 0 decided hold (balanced event 3)
-kp_pressed: usage_page 0x07 keycode 0xe1
-kp_released: usage_page 0x07 keycode 0xe1
+kp_pressed: usage_page 0x07 keycode 0xe1 mods 0x00
+kp_released: usage_page 0x07 keycode 0xe1 mods 0x00
 ht_binding_released: 0 cleaning up hold-tap
--- a/app/tests/hold-tap/balanced/3a-moddn-dn-modup-up/keycode_events.snapshot
+++ b/app/tests/hold-tap/balanced/3a-moddn-dn-modup-up/keycode_events.snapshot
@@ -1,7 +1,7 @@
-kp_pressed: usage_page 0x07 keycode 0xe4
+kp_pressed: usage_page 0x07 keycode 0xe4 mods 0x00
 ht_binding_pressed: 0 new undecided hold_tap
 ht_decide: 0 decided tap (balanced event 0)
-kp_pressed: usage_page 0x07 keycode 0x09
-kp_released: usage_page 0x07 keycode 0xe4
-kp_released: usage_page 0x07 keycode 0x09
+kp_pressed: usage_page 0x07 keycode 0x09 mods 0x00
+kp_released: usage_page 0x07 keycode 0xe4 mods 0x00
+kp_released: usage_page 0x07 keycode 0x09 mods 0x00
 ht_binding_released: 0 cleaning up hold-tap
--- a/app/tests/hold-tap/balanced/3b-moddn-dn-modup-timer-up/keycode_events.snapshot
+++ b/app/tests/hold-tap/balanced/3b-moddn-dn-modup-timer-up/keycode_events.snapshot
@@ -1,7 +1,7 @@
-kp_pressed: usage_page 0x07 keycode 0xe4
+kp_pressed: usage_page 0x07 keycode 0xe4 mods 0x00
 ht_binding_pressed: 0 new undecided hold_tap
 ht_decide: 0 decided hold (balanced event 3)
-kp_pressed: usage_page 0x07 keycode 0xe1
-kp_released: usage_page 0x07 keycode 0xe4
-kp_released: usage_page 0x07 keycode 0xe1
+kp_pressed: usage_page 0x07 keycode 0xe1 mods 0x00
+kp_released: usage_page 0x07 keycode 0xe4 mods 0x00
+kp_released: usage_page 0x07 keycode 0xe1 mods 0x00
 ht_binding_released: 0 cleaning up hold-tap
--- a/app/tests/hold-tap/balanced/3c-kcdn-dn-kcup-up/keycode_events.snapshot
+++ b/app/tests/hold-tap/balanced/3c-kcdn-dn-kcup-up/keycode_events.snapshot
@@ -1,7 +1,7 @@
-kp_pressed: usage_page 0x07 keycode 0x07
+kp_pressed: usage_page 0x07 keycode 0x07 mods 0x00
 ht_binding_pressed: 0 new undecided hold_tap
-kp_released: usage_page 0x07 keycode 0x07
+kp_released: usage_page 0x07 keycode 0x07 mods 0x00
 ht_decide: 0 decided tap (balanced event 0)
-kp_pressed: usage_page 0x07 keycode 0x09
-kp_released: usage_page 0x07 keycode 0x09
+kp_pressed: usage_page 0x07 keycode 0x09 mods 0x00
+kp_released: usage_page 0x07 keycode 0x09 mods 0x00
 ht_binding_released: 0 cleaning up hold-tap
--- a/app/tests/hold-tap/balanced/3d-kcdn-dn-kcup-timer-up/keycode_events.snapshot
+++ b/app/tests/hold-tap/balanced/3d-kcdn-dn-kcup-timer-up/keycode_events.snapshot
@@ -1,7 +1,7 @@
-kp_pressed: usage_page 0x07 keycode 0x07
+kp_pressed: usage_page 0x07 keycode 0x07 mods 0x00
 ht_binding_pressed: 0 new undecided hold_tap
-kp_released: usage_page 0x07 keycode 0x07
+kp_released: usage_page 0x07 keycode 0x07 mods 0x00
 ht_decide: 0 decided hold (balanced event 3)
-kp_pressed: usage_page 0x07 keycode 0xe1
-kp_released: usage_page 0x07 keycode 0xe1
+kp_pressed: usage_page 0x07 keycode 0xe1 mods 0x00
+kp_released: usage_page 0x07 keycode 0xe1 mods 0x00
 ht_binding_released: 0 cleaning up hold-tap
--- a/app/tests/hold-tap/balanced/4a-dn-htdn-timer-htup-up/keycode_events.snapshot
+++ b/app/tests/hold-tap/balanced/4a-dn-htdn-timer-htup-up/keycode_events.snapshot
@@ -1,10 +1,10 @@
 ht_binding_pressed: 0 new undecided hold_tap
 ht_decide: 0 decided hold (balanced event 3)
-kp_pressed: usage_page 0x07 keycode 0xe1
+kp_pressed: usage_page 0x07 keycode 0xe1 mods 0x00
 ht_binding_pressed: 1 new undecided hold_tap
 ht_decide: 1 decided tap (balanced event 0)
-kp_pressed: usage_page 0x07 keycode 0x0d
-kp_released: usage_page 0x07 keycode 0x0d
+kp_pressed: usage_page 0x07 keycode 0x0d mods 0x00
+kp_released: usage_page 0x07 keycode 0x0d mods 0x00
 ht_binding_released: 1 cleaning up hold-tap
-kp_released: usage_page 0x07 keycode 0xe1
+kp_released: usage_page 0x07 keycode 0xe1 mods 0x00
 ht_binding_released: 0 cleaning up hold-tap
--- a/app/tests/hold-tap/balanced/4a-dn-kcdn-timer-kcup-up/keycode_events.snapshot
+++ b/app/tests/hold-tap/balanced/4a-dn-kcdn-timer-kcup-up/keycode_events.snapshot
@@ -1,7 +1,7 @@
 ht_binding_pressed: 0 new undecided hold_tap
 ht_decide: 0 decided hold (balanced event 3)
-kp_pressed: usage_page 0x07 keycode 0xe1
-kp_pressed: usage_page 0x07 keycode 0x07
-kp_released: usage_page 0x07 keycode 0x07
-kp_released: usage_page 0x07 keycode 0xe1
+kp_pressed: usage_page 0x07 keycode 0xe1 mods 0x00
+kp_pressed: usage_page 0x07 keycode 0x07 mods 0x00
+kp_released: usage_page 0x07 keycode 0x07 mods 0x00
+kp_released: usage_page 0x07 keycode 0xe1 mods 0x00
 ht_binding_released: 0 cleaning up hold-tap
--- a/app/tests/hold-tap/balanced/4b-dn-kcdn-kcup-timer-up/keycode_events.snapshot
+++ b/app/tests/hold-tap/balanced/4b-dn-kcdn-kcup-timer-up/keycode_events.snapshot
@@ -1,7 +1,7 @@
 ht_binding_pressed: 0 new undecided hold_tap
 ht_decide: 0 decided hold (balanced event 2)
-kp_pressed: usage_page 0x07 keycode 0xe1
-kp_pressed: usage_page 0x07 keycode 0x07
-kp_released: usage_page 0x07 keycode 0x07
-kp_released: usage_page 0x07 keycode 0xe1
+kp_pressed: usage_page 0x07 keycode 0xe1 mods 0x00
+kp_pressed: usage_page 0x07 keycode 0x07 mods 0x00
+kp_released: usage_page 0x07 keycode 0x07 mods 0x00
+kp_released: usage_page 0x07 keycode 0xe1 mods 0x00
 ht_binding_released: 0 cleaning up hold-tap
--- a/app/tests/hold-tap/balanced/4c-dn-kcdn-kcup-up/keycode_events.snapshot
+++ b/app/tests/hold-tap/balanced/4c-dn-kcdn-kcup-up/keycode_events.snapshot
@@ -1,7 +1,7 @@
 ht_binding_pressed: 0 new undecided hold_tap
 ht_decide: 0 decided hold (balanced event 2)
-kp_pressed: usage_page 0x07 keycode 0xe1
-kp_pressed: usage_page 0x07 keycode 0x07
-kp_released: usage_page 0x07 keycode 0x07
-kp_released: usage_page 0x07 keycode 0xe1
+kp_pressed: usage_page 0x07 keycode 0xe1 mods 0x00
+kp_pressed: usage_page 0x07 keycode 0x07 mods 0x00
+kp_released: usage_page 0x07 keycode 0x07 mods 0x00
+kp_released: usage_page 0x07 keycode 0xe1 mods 0x00
 ht_binding_released: 0 cleaning up hold-tap
--- a/app/tests/hold-tap/balanced/4d-dn-kcdn-timer-up-kcup/keycode_events.snapshot
+++ b/app/tests/hold-tap/balanced/4d-dn-kcdn-timer-up-kcup/keycode_events.snapshot
@@ -1,7 +1,7 @@
 ht_binding_pressed: 0 new undecided hold_tap
 ht_decide: 0 decided tap (balanced event 0)
-kp_pressed: usage_page 0x07 keycode 0x09
-kp_pressed: usage_page 0x07 keycode 0x07
-kp_released: usage_page 0x07 keycode 0x09
+kp_pressed: usage_page 0x07 keycode 0x09 mods 0x00
+kp_pressed: usage_page 0x07 keycode 0x07 mods 0x00
+kp_released: usage_page 0x07 keycode 0x09 mods 0x00
 ht_binding_released: 0 cleaning up hold-tap
-kp_released: usage_page 0x07 keycode 0x07
+kp_released: usage_page 0x07 keycode 0x07 mods 0x00
--- a/app/tests/hold-tap/balanced/many-nested/keycode_events.snapshot
+++ b/app/tests/hold-tap/balanced/many-nested/keycode_events.snapshot
@@ -1,20 +1,20 @@
 ht_binding_pressed: 0 new undecided hold_tap
 ht_decide: 0 decided hold (balanced event 3)
-kp_pressed: usage_page 0x07 keycode 0xe1
+kp_pressed: usage_page 0x07 keycode 0xe1 mods 0x00
 ht_binding_pressed: 1 new undecided hold_tap
 ht_decide: 1 decided hold (balanced event 3)
-kp_pressed: usage_page 0x07 keycode 0xe0
+kp_pressed: usage_page 0x07 keycode 0xe0 mods 0x00
 ht_binding_pressed: 2 new undecided hold_tap
 ht_binding_released: 0 cleaning up hold-tap
 ht_decide: 2 decided hold (balanced event 3)
-kp_pressed: usage_page 0x07 keycode 0xe3
+kp_pressed: usage_page 0x07 keycode 0xe3 mods 0x00
 ht_binding_pressed: 3 new undecided hold_tap
 ht_binding_released: 1 cleaning up hold-tap
 ht_decide: 3 decided hold (balanced event 3)
-kp_pressed: usage_page 0x07 keycode 0xe2
-kp_released: usage_page 0x07 keycode 0xe1
-kp_released: usage_page 0x07 keycode 0xe0
-kp_released: usage_page 0x07 keycode 0xe3
+kp_pressed: usage_page 0x07 keycode 0xe2 mods 0x00
+kp_released: usage_page 0x07 keycode 0xe1 mods 0x00
+kp_released: usage_page 0x07 keycode 0xe0 mods 0x00
+kp_released: usage_page 0x07 keycode 0xe3 mods 0x00
 ht_binding_released: 2 cleaning up hold-tap
-kp_released: usage_page 0x07 keycode 0xe2
+kp_released: usage_page 0x07 keycode 0xe2 mods 0x00
 ht_binding_released: 3 cleaning up hold-tap
--- a/app/tests/hold-tap/hold-preferred/1-dn-up/keycode_events.snapshot
+++ b/app/tests/hold-tap/hold-preferred/1-dn-up/keycode_events.snapshot
@@ -1,5 +1,5 @@
 ht_binding_pressed: 0 new undecided hold_tap
 ht_decide: 0 decided tap (hold-preferred event 0)
-kp_pressed: usage_page 0x07 keycode 0x09
-kp_released: usage_page 0x07 keycode 0x09
+kp_pressed: usage_page 0x07 keycode 0x09 mods 0x00
+kp_released: usage_page 0x07 keycode 0x09 mods 0x00
 ht_binding_released: 0 cleaning up hold-tap
--- a/app/tests/hold-tap/hold-preferred/2-dn-timer-up/keycode_events.snapshot
+++ b/app/tests/hold-tap/hold-preferred/2-dn-timer-up/keycode_events.snapshot
@@ -1,5 +1,5 @@
 ht_binding_pressed: 0 new undecided hold_tap
 ht_decide: 0 decided hold (hold-preferred event 3)
-kp_pressed: usage_page 0x07 keycode 0xe1
-kp_released: usage_page 0x07 keycode 0xe1
+kp_pressed: usage_page 0x07 keycode 0xe1 mods 0x00
+kp_released: usage_page 0x07 keycode 0xe1 mods 0x00
 ht_binding_released: 0 cleaning up hold-tap
--- a/app/tests/hold-tap/hold-preferred/3a-moddn-dn-modup-up/keycode_events.snapshot
+++ b/app/tests/hold-tap/hold-preferred/3a-moddn-dn-modup-up/keycode_events.snapshot
@@ -1,7 +1,7 @@
-kp_pressed: usage_page 0x07 keycode 0xe4
+kp_pressed: usage_page 0x07 keycode 0xe4 mods 0x00
 ht_binding_pressed: 0 new undecided hold_tap
 ht_decide: 0 decided tap (hold-preferred event 0)
-kp_pressed: usage_page 0x07 keycode 0x09
-kp_released: usage_page 0x07 keycode 0xe4
-kp_released: usage_page 0x07 keycode 0x09
+kp_pressed: usage_page 0x07 keycode 0x09 mods 0x00
+kp_released: usage_page 0x07 keycode 0xe4 mods 0x00
+kp_released: usage_page 0x07 keycode 0x09 mods 0x00
 ht_binding_released: 0 cleaning up hold-tap
--- a/app/tests/hold-tap/hold-preferred/3b-moddn-dn-modup-timer-up/keycode_events.snapshot
+++ b/app/tests/hold-tap/hold-preferred/3b-moddn-dn-modup-timer-up/keycode_events.snapshot
@@ -1,7 +1,7 @@
-kp_pressed: usage_page 0x07 keycode 0xe4
+kp_pressed: usage_page 0x07 keycode 0xe4 mods 0x00
 ht_binding_pressed: 0 new undecided hold_tap
 ht_decide: 0 decided hold (hold-preferred event 3)
-kp_pressed: usage_page 0x07 keycode 0xe1
-kp_released: usage_page 0x07 keycode 0xe4
-kp_released: usage_page 0x07 keycode 0xe1
+kp_pressed: usage_page 0x07 keycode 0xe1 mods 0x00
+kp_released: usage_page 0x07 keycode 0xe4 mods 0x00
+kp_released: usage_page 0x07 keycode 0xe1 mods 0x00
 ht_binding_released: 0 cleaning up hold-tap
--- a/app/tests/hold-tap/hold-preferred/3c-kcdn-dn-kcup-up/keycode_events.snapshot
+++ b/app/tests/hold-tap/hold-preferred/3c-kcdn-dn-kcup-up/keycode_events.snapshot
@@ -1,7 +1,7 @@
-kp_pressed: usage_page 0x07 keycode 0x07
+kp_pressed: usage_page 0x07 keycode 0x07 mods 0x00
 ht_binding_pressed: 0 new undecided hold_tap
-kp_released: usage_page 0x07 keycode 0x07
+kp_released: usage_page 0x07 keycode 0x07 mods 0x00
 ht_decide: 0 decided tap (hold-preferred event 0)
-kp_pressed: usage_page 0x07 keycode 0x09
-kp_released: usage_page 0x07 keycode 0x09
+kp_pressed: usage_page 0x07 keycode 0x09 mods 0x00
+kp_released: usage_page 0x07 keycode 0x09 mods 0x00
 ht_binding_released: 0 cleaning up hold-tap
--- a/app/tests/hold-tap/hold-preferred/3d-kcdn-dn-kcup-timer-up/keycode_events.snapshot
+++ b/app/tests/hold-tap/hold-preferred/3d-kcdn-dn-kcup-timer-up/keycode_events.snapshot
@@ -1,7 +1,7 @@
-kp_pressed: usage_page 0x07 keycode 0x07
+kp_pressed: usage_page 0x07 keycode 0x07 mods 0x00
 ht_binding_pressed: 0 new undecided hold_tap
-kp_released: usage_page 0x07 keycode 0x07
+kp_released: usage_page 0x07 keycode 0x07 mods 0x00
 ht_decide: 0 decided hold (hold-preferred event 3)
-kp_pressed: usage_page 0x07 keycode 0xe1
-kp_released: usage_page 0x07 keycode 0xe1
+kp_pressed: usage_page 0x07 keycode 0xe1 mods 0x00
+kp_released: usage_page 0x07 keycode 0xe1 mods 0x00
 ht_binding_released: 0 cleaning up hold-tap
--- a/app/tests/hold-tap/hold-preferred/4a-dn-htdn-timer-htup-up/keycode_events.snapshot
+++ b/app/tests/hold-tap/hold-preferred/4a-dn-htdn-timer-htup-up/keycode_events.snapshot
@@ -1,10 +1,10 @@
 ht_binding_pressed: 0 new undecided hold_tap
 ht_decide: 0 decided hold (hold-preferred event 1)
-kp_pressed: usage_page 0x07 keycode 0xe1
+kp_pressed: usage_page 0x07 keycode 0xe1 mods 0x00
 ht_binding_pressed: 1 new undecided hold_tap
 ht_decide: 1 decided tap (hold-preferred event 0)
-kp_pressed: usage_page 0x07 keycode 0x0d
-kp_released: usage_page 0x07 keycode 0x0d
+kp_pressed: usage_page 0x07 keycode 0x0d mods 0x00
+kp_released: usage_page 0x07 keycode 0x0d mods 0x00
 ht_binding_released: 1 cleaning up hold-tap
-kp_released: usage_page 0x07 keycode 0xe1
+kp_released: usage_page 0x07 keycode 0xe1 mods 0x00
 ht_binding_released: 0 cleaning up hold-tap
--- a/app/tests/hold-tap/hold-preferred/4a-dn-kcdn-timer-kcup-up/keycode_events.snapshot
+++ b/app/tests/hold-tap/hold-preferred/4a-dn-kcdn-timer-kcup-up/keycode_events.snapshot
@@ -1,7 +1,7 @@
 ht_binding_pressed: 0 new undecided hold_tap
 ht_decide: 0 decided hold (hold-preferred event 1)
-kp_pressed: usage_page 0x07 keycode 0xe1
-kp_pressed: usage_page 0x07 keycode 0x07
-kp_released: usage_page 0x07 keycode 0x07
-kp_released: usage_page 0x07 keycode 0xe1
+kp_pressed: usage_page 0x07 keycode 0xe1 mods 0x00
+kp_pressed: usage_page 0x07 keycode 0x07 mods 0x00
+kp_released: usage_page 0x07 keycode 0x07 mods 0x00
+kp_released: usage_page 0x07 keycode 0xe1 mods 0x00
 ht_binding_released: 0 cleaning up hold-tap
--- a/app/tests/hold-tap/hold-preferred/4b-dn-kcdn-kcup-timer-up/keycode_events.snapshot
+++ b/app/tests/hold-tap/hold-preferred/4b-dn-kcdn-kcup-timer-up/keycode_events.snapshot
@@ -1,7 +1,7 @@
 ht_binding_pressed: 0 new undecided hold_tap
 ht_decide: 0 decided hold (hold-preferred event 1)
-kp_pressed: usage_page 0x07 keycode 0xe1
-kp_pressed: usage_page 0x07 keycode 0x07
-kp_released: usage_page 0x07 keycode 0x07
-kp_released: usage_page 0x07 keycode 0xe1
+kp_pressed: usage_page 0x07 keycode 0xe1 mods 0x00
+kp_pressed: usage_page 0x07 keycode 0x07 mods 0x00
+kp_released: usage_page 0x07 keycode 0x07 mods 0x00
+kp_released: usage_page 0x07 keycode 0xe1 mods 0x00
 ht_binding_released: 0 cleaning up hold-tap
--- a/app/tests/hold-tap/hold-preferred/4c-dn-kcdn-kcup-up/keycode_events.snapshot
+++ b/app/tests/hold-tap/hold-preferred/4c-dn-kcdn-kcup-up/keycode_events.snapshot
@@ -1,7 +1,7 @@
 ht_binding_pressed: 0 new undecided hold_tap
 ht_decide: 0 decided hold (hold-preferred event 1)
-kp_pressed: usage_page 0x07 keycode 0xe1
-kp_pressed: usage_page 0x07 keycode 0x07
-kp_released: usage_page 0x07 keycode 0x07
-kp_released: usage_page 0x07 keycode 0xe1
+kp_pressed: usage_page 0x07 keycode 0xe1 mods 0x00
+kp_pressed: usage_page 0x07 keycode 0x07 mods 0x00
+kp_released: usage_page 0x07 keycode 0x07 mods 0x00
+kp_released: usage_page 0x07 keycode 0xe1 mods 0x00
 ht_binding_released: 0 cleaning up hold-tap
--- a/app/tests/hold-tap/hold-preferred/4d-dn-kcdn-timer-up-kcup/keycode_events.snapshot
+++ b/app/tests/hold-tap/hold-preferred/4d-dn-kcdn-timer-up-kcup/keycode_events.snapshot
@@ -1,7 +1,7 @@
 ht_binding_pressed: 0 new undecided hold_tap
 ht_decide: 0 decided hold (hold-preferred event 1)
-kp_pressed: usage_page 0x07 keycode 0xe1
-kp_pressed: usage_page 0x07 keycode 0x07
-kp_released: usage_page 0x07 keycode 0xe1
+kp_pressed: usage_page 0x07 keycode 0xe1 mods 0x00
+kp_pressed: usage_page 0x07 keycode 0x07 mods 0x00
+kp_released: usage_page 0x07 keycode 0xe1 mods 0x00
 ht_binding_released: 0 cleaning up hold-tap
-kp_released: usage_page 0x07 keycode 0x07
+kp_released: usage_page 0x07 keycode 0x07 mods 0x00
--- a/app/tests/hold-tap/tap-preferred/1-dn-up/keycode_events.snapshot
+++ b/app/tests/hold-tap/tap-preferred/1-dn-up/keycode_events.snapshot
@@ -1,5 +1,5 @@
 ht_binding_pressed: 0 new undecided hold_tap
 ht_decide: 0 decided tap (tap-preferred event 0)
-kp_pressed: usage_page 0x07 keycode 0x09
-kp_released: usage_page 0x07 keycode 0x09
+kp_pressed: usage_page 0x07 keycode 0x09 mods 0x00
+kp_released: usage_page 0x07 keycode 0x09 mods 0x00
 ht_binding_released: 0 cleaning up hold-tap
--- a/app/tests/hold-tap/tap-preferred/2-dn-timer-up/keycode_events.snapshot
+++ b/app/tests/hold-tap/tap-preferred/2-dn-timer-up/keycode_events.snapshot
@@ -1,5 +1,5 @@
 ht_binding_pressed: 0 new undecided hold_tap
 ht_decide: 0 decided hold (tap-preferred event 3)
-kp_pressed: usage_page 0x07 keycode 0xe1
-kp_released: usage_page 0x07 keycode 0xe1
+kp_pressed: usage_page 0x07 keycode 0xe1 mods 0x00
+kp_released: usage_page 0x07 keycode 0xe1 mods 0x00
 ht_binding_released: 0 cleaning up hold-tap
--- a/app/tests/hold-tap/tap-preferred/3a-moddn-dn-modup-up/keycode_events.snapshot
+++ b/app/tests/hold-tap/tap-preferred/3a-moddn-dn-modup-up/keycode_events.snapshot
@@ -1,7 +1,7 @@
-kp_pressed: usage_page 0x07 keycode 0xe4
+kp_pressed: usage_page 0x07 keycode 0xe4 mods 0x00
 ht_binding_pressed: 0 new undecided hold_tap
 ht_decide: 0 decided tap (tap-preferred event 0)
-kp_pressed: usage_page 0x07 keycode 0x09
-kp_released: usage_page 0x07 keycode 0xe4
-kp_released: usage_page 0x07 keycode 0x09
+kp_pressed: usage_page 0x07 keycode 0x09 mods 0x00
+kp_released: usage_page 0x07 keycode 0xe4 mods 0x00
+kp_released: usage_page 0x07 keycode 0x09 mods 0x00
 ht_binding_released: 0 cleaning up hold-tap
--- a/app/tests/hold-tap/tap-preferred/3b-moddn-dn-modup-timer-up/keycode_events.snapshot
+++ b/app/tests/hold-tap/tap-preferred/3b-moddn-dn-modup-timer-up/keycode_events.snapshot
@@ -1,7 +1,7 @@
-kp_pressed: usage_page 0x07 keycode 0xe4
+kp_pressed: usage_page 0x07 keycode 0xe4 mods 0x00
 ht_binding_pressed: 0 new undecided hold_tap
 ht_decide: 0 decided hold (tap-preferred event 3)
-kp_pressed: usage_page 0x07 keycode 0xe1
-kp_released: usage_page 0x07 keycode 0xe4
-kp_released: usage_page 0x07 keycode 0xe1
+kp_pressed: usage_page 0x07 keycode 0xe1 mods 0x00
+kp_released: usage_page 0x07 keycode 0xe4 mods 0x00
+kp_released: usage_page 0x07 keycode 0xe1 mods 0x00
 ht_binding_released: 0 cleaning up hold-tap
--- a/app/tests/hold-tap/tap-preferred/3c-kcdn-dn-kcup-up/keycode_events.snapshot
+++ b/app/tests/hold-tap/tap-preferred/3c-kcdn-dn-kcup-up/keycode_events.snapshot
@@ -1,7 +1,7 @@
-kp_pressed: usage_page 0x07 keycode 0x07
+kp_pressed: usage_page 0x07 keycode 0x07 mods 0x00
 ht_binding_pressed: 0 new undecided hold_tap
-kp_released: usage_page 0x07 keycode 0x07
+kp_released: usage_page 0x07 keycode 0x07 mods 0x00
 ht_decide: 0 decided tap (tap-preferred event 0)
-kp_pressed: usage_page 0x07 keycode 0x09
-kp_released: usage_page 0x07 keycode 0x09
+kp_pressed: usage_page 0x07 keycode 0x09 mods 0x00
+kp_released: usage_page 0x07 keycode 0x09 mods 0x00
 ht_binding_released: 0 cleaning up hold-tap
--- a/app/tests/hold-tap/tap-preferred/3d-kcdn-dn-kcup-timer-up/keycode_events.snapshot
+++ b/app/tests/hold-tap/tap-preferred/3d-kcdn-dn-kcup-timer-up/keycode_events.snapshot
@@ -1,7 +1,7 @@
-kp_pressed: usage_page 0x07 keycode 0x07
+kp_pressed: usage_page 0x07 keycode 0x07 mods 0x00
 ht_binding_pressed: 0 new undecided hold_tap
-kp_released: usage_page 0x07 keycode 0x07
+kp_released: usage_page 0x07 keycode 0x07 mods 0x00
 ht_decide: 0 decided hold (tap-preferred event 3)
-kp_pressed: usage_page 0x07 keycode 0xe1
-kp_released: usage_page 0x07 keycode 0xe1
+kp_pressed: usage_page 0x07 keycode 0xe1 mods 0x00
+kp_released: usage_page 0x07 keycode 0xe1 mods 0x00
 ht_binding_released: 0 cleaning up hold-tap
--- a/app/tests/hold-tap/tap-preferred/4a-dn-htdn-timer-htup-up/keycode_events.snapshot
+++ b/app/tests/hold-tap/tap-preferred/4a-dn-htdn-timer-htup-up/keycode_events.snapshot
@@ -1,10 +1,10 @@
 ht_binding_pressed: 0 new undecided hold_tap
 ht_decide: 0 decided hold (tap-preferred event 3)
-kp_pressed: usage_page 0x07 keycode 0xe1
+kp_pressed: usage_page 0x07 keycode 0xe1 mods 0x00
 ht_binding_pressed: 1 new undecided hold_tap
 ht_decide: 1 decided tap (tap-preferred event 0)
-kp_pressed: usage_page 0x07 keycode 0x0d
-kp_released: usage_page 0x07 keycode 0x0d
+kp_pressed: usage_page 0x07 keycode 0x0d mods 0x00
+kp_released: usage_page 0x07 keycode 0x0d mods 0x00
 ht_binding_released: 1 cleaning up hold-tap
-kp_released: usage_page 0x07 keycode 0xe1
+kp_released: usage_page 0x07 keycode 0xe1 mods 0x00
 ht_binding_released: 0 cleaning up hold-tap
--- a/app/tests/hold-tap/tap-preferred/4a-dn-kcdn-timer-kcup-up/keycode_events.snapshot
+++ b/app/tests/hold-tap/tap-preferred/4a-dn-kcdn-timer-kcup-up/keycode_events.snapshot
@@ -1,7 +1,7 @@
 ht_binding_pressed: 0 new undecided hold_tap
 ht_decide: 0 decided hold (tap-preferred event 3)
-kp_pressed: usage_page 0x07 keycode 0xe1
-kp_pressed: usage_page 0x07 keycode 0x07
-kp_released: usage_page 0x07 keycode 0x07
-kp_released: usage_page 0x07 keycode 0xe1
+kp_pressed: usage_page 0x07 keycode 0xe1 mods 0x00
+kp_pressed: usage_page 0x07 keycode 0x07 mods 0x00
+kp_released: usage_page 0x07 keycode 0x07 mods 0x00
+kp_released: usage_page 0x07 keycode 0xe1 mods 0x00
 ht_binding_released: 0 cleaning up hold-tap
--- a/app/tests/hold-tap/tap-preferred/4b-dn-kcdn-kcup-timer-up/keycode_events.snapshot
+++ b/app/tests/hold-tap/tap-preferred/4b-dn-kcdn-kcup-timer-up/keycode_events.snapshot
@@ -1,7 +1,7 @@
 ht_binding_pressed: 0 new undecided hold_tap
 ht_decide: 0 decided hold (tap-preferred event 3)
-kp_pressed: usage_page 0x07 keycode 0xe1
-kp_pressed: usage_page 0x07 keycode 0x07
-kp_released: usage_page 0x07 keycode 0x07
-kp_released: usage_page 0x07 keycode 0xe1
+kp_pressed: usage_page 0x07 keycode 0xe1 mods 0x00
+kp_pressed: usage_page 0x07 keycode 0x07 mods 0x00
+kp_released: usage_page 0x07 keycode 0x07 mods 0x00
+kp_released: usage_page 0x07 keycode 0xe1 mods 0x00
 ht_binding_released: 0 cleaning up hold-tap
--- a/app/tests/hold-tap/tap-preferred/4c-dn-kcdn-kcup-up/keycode_events.snapshot
+++ b/app/tests/hold-tap/tap-preferred/4c-dn-kcdn-kcup-up/keycode_events.snapshot
@@ -1,7 +1,7 @@
 ht_binding_pressed: 0 new undecided hold_tap
 ht_decide: 0 decided tap (tap-preferred event 0)
-kp_pressed: usage_page 0x07 keycode 0x09
-kp_pressed: usage_page 0x07 keycode 0x07
-kp_released: usage_page 0x07 keycode 0x07
-kp_released: usage_page 0x07 keycode 0x09
+kp_pressed: usage_page 0x07 keycode 0x09 mods 0x00
+kp_pressed: usage_page 0x07 keycode 0x07 mods 0x00
+kp_released: usage_page 0x07 keycode 0x07 mods 0x00
+kp_released: usage_page 0x07 keycode 0x09 mods 0x00
 ht_binding_released: 0 cleaning up hold-tap
--- a/app/tests/hold-tap/tap-preferred/4d-dn-kcdn-timer-up-kcup/keycode_events.snapshot
+++ b/app/tests/hold-tap/tap-preferred/4d-dn-kcdn-timer-up-kcup/keycode_events.snapshot
@@ -1,7 +1,7 @@
 ht_binding_pressed: 0 new undecided hold_tap
 ht_decide: 0 decided tap (tap-preferred event 0)
-kp_pressed: usage_page 0x07 keycode 0x09
-kp_pressed: usage_page 0x07 keycode 0x07
-kp_released: usage_page 0x07 keycode 0x09
+kp_pressed: usage_page 0x07 keycode 0x09 mods 0x00
+kp_pressed: usage_page 0x07 keycode 0x07 mods 0x00
+kp_released: usage_page 0x07 keycode 0x09 mods 0x00
 ht_binding_released: 0 cleaning up hold-tap
-kp_released: usage_page 0x07 keycode 0x07
+kp_released: usage_page 0x07 keycode 0x07 mods 0x00