Jacob/zmk
1
0
Fork 0
forked from kofal.net/zmk
Code Pull Requests Activity

initial implementation for modifiers

Browse Source 
https://github.com/zmkfirmware/zmk/issues/86
This commit is contained in:
Okke Formsma
2020-09-02 22:30:09 +02:00
committed by Pete Johanson
parent a9e729b427
commit 4f258efbf1
77 changed files with 597 additions and 229 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
app/tests/modifiers/implicit/kp-mod1-dn-mod2-dn-mod1-up-mod2-up/pending Normal file
View File

@@ -0,0 +1,9 @@
This test fails because the hid_listener_keycode_released function
releases implicit modifiers always, even if they were not set by the
key that's going up. Also see the comment in that function:
If LC(A) is pressed, then LS(B), then LC(A) is released, the shift for B will be released
prematurely. This causes if LS(B) to repeat like Bbbbbbbb when pressed for a long time.
Solving this would require keeping track of which key's implicit modifiers are currently
active and only releasing modifiers at that time.