Jacob/zmk
1
0
Fork 0
forked from kofal.net/zmk
Code Pull Requests Activity

fix(core): Address review comments from Joel.

Browse Source 
* Fix up some lingering events API tweaks for heap-less event manager.
This commit is contained in:
Peter Johanson
2024-01-13 21:17:35 +00:00
committed by Pete Johanson
parent 33209dee1d
commit 644feeb40d
6 changed files with 26 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
app/src/combo.c
View File

@@ -274,14 +274,14 @@ static int release_pressed_keys() {
uint32_t count = pressed_keys_count;
pressed_keys_count = 0;
for (int i = 0; i < count; i++) {
struct zmk_position_state_changed_event ev = pressed_keys[i];
struct zmk_position_state_changed_event *ev = &pressed_keys[i];
if (i == 0) {
LOG_DBG("combo: releasing position event %d", ev.data.position);
ZMK_EVENT_RELEASE(ev)
LOG_DBG("combo: releasing position event %d", ev->data.position);
ZMK_EVENT_RELEASE(*ev);
} else {
// reprocess events (see tests/combo/fully-overlapping-combos-3 for why this is needed)
LOG_DBG("combo: reraising position event %d", ev.data.position);
ZMK_EVENT_RAISE(ev);
LOG_DBG("combo: reraising position event %d", ev->data.position);
ZMK_EVENT_RAISE(*ev);
}
}