Jacob/zmk
1
0
Fork 0
forked from kofal.net/zmk
Code Pull Requests Activity

lint: add (void) parameter to pass -Wstrict-prototypes

Browse Source 
Note there was one place where a non-strict prototype was actually being used
with an argument, in `zmk_hog_init`. In this case, the actual argument type was
added instead.
This commit is contained in:
Chris Andreae
2023-12-18 22:16:19 +09:00
committed by Pete Johanson
parent 5257cde1f5
commit 7a5155f36e
28 changed files with 117 additions and 109 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
app/src/backlight.c
View File

@@ -42,7 +42,7 @@ struct backlight_state {
static struct backlight_state state = {.brightness = CONFIG_ZMK_BACKLIGHT_BRT_START,
.on = IS_ENABLED(CONFIG_ZMK_BACKLIGHT_ON_START)};
static int zmk_backlight_update() {
static int zmk_backlight_update(void) {
uint8_t brt = zmk_backlight_get_brt();
LOG_DBG("Update backlight brightness: %d%%", brt);
@@ -98,7 +98,7 @@ static int zmk_backlight_init(const struct device *_arg) {
return zmk_backlight_update();
}
static int zmk_backlight_update_and_save() {
static int zmk_backlight_update_and_save(void) {
int rc = zmk_backlight_update();
if (rc != 0) {
return rc;
@@ -112,20 +112,20 @@ static int zmk_backlight_update_and_save() {
#endif
}
int zmk_backlight_on() {
int zmk_backlight_on(void) {
state.brightness = MAX(state.brightness, CONFIG_ZMK_BACKLIGHT_BRT_STEP);
state.on = true;
return zmk_backlight_update_and_save();
}
int zmk_backlight_off() {
int zmk_backlight_off(void) {
state.on = false;
return zmk_backlight_update_and_save();
}
int zmk_backlight_toggle() { return state.on ? zmk_backlight_off() : zmk_backlight_on(); }
int zmk_backlight_toggle(void) { return state.on ? zmk_backlight_off() : zmk_backlight_on(); }
bool zmk_backlight_is_on() { return state.on; }
bool zmk_backlight_is_on(void) { return state.on; }
int zmk_backlight_set_brt(uint8_t brightness) {
state.brightness = MIN(brightness, BRT_MAX);
@@ -133,14 +133,14 @@ int zmk_backlight_set_brt(uint8_t brightness) {
return zmk_backlight_update_and_save();
}
uint8_t zmk_backlight_get_brt() { return state.on ? state.brightness : 0; }
uint8_t zmk_backlight_get_brt(void) { return state.on ? state.brightness : 0; }
uint8_t zmk_backlight_calc_brt(int direction) {
int brt = state.brightness + (direction * CONFIG_ZMK_BACKLIGHT_BRT_STEP);
return CLAMP(brt, 0, BRT_MAX);
}
uint8_t zmk_backlight_calc_brt_cycle() {
uint8_t zmk_backlight_calc_brt_cycle(void) {
if (state.brightness == BRT_MAX) {
return 0;
} else {