forked from kofal.net/zmk
* Add gitlint to pre-commit setup * Update pre-commit setup for installing commit-hooks * Add "Commit Conventions" contributing docs Co-authored-by: Cem Aksoylar <caksoylar@users.noreply.github.com>
3.5 KiB
3.5 KiB
title
| title |
|---|
| Commit Messages |
The ZMK project uses conventional commits for their commit messages. This not only provides consistency for our commits, but also allows for release/versioning automation to determine the next version to release, generating changelogs, etc.
Commit messages will be checked as part of our CI process by GitHub Actions.
Guidelines
Commits should have the following:
- A first line prefix that includes a type, as well as appropriate scope in parentheses as needed.
- Following the prefix, a concise summary of the change, which documents the new behavior/feature/functionality in the positive (e.g. "wake from sleep now works with charlieplex kscan", not "fixed waked from sleep bug with charlieplex kscan driver").
- A blank line following the first line.
- A body that provides more detail of the changes. This may be a bulleted list or paragraph prose.
- An optional set of git trailers for things like GitHub keywords following a blank line.
Example
Here is an example of a good commit message:
feat(boards): Add numpad layouts
Added physical layouts for the following variants of numpads:
- With and without extra top row
- 2U plus key or 1U plus and backspace keys
- 2U 0 key or 1U 0 and 00 keys
- Full 1U grid/macropad layout
Other layouts exist, such as "southpaw" horizontally mirrored layouts,
and layouts with a fifth column, but those seem to be much less common.
Pre-Commit
To help make sure you don't need to wait for GitHub Actions to check your commits, you can set up pre-commit to check your commits as you create them.
Types
The following commit types are used by ZMK:
blog:-- changes to our documentation found in thedocs/blogdirectorydocs:-- changes to our documentation found in thedocs/directory, except blogsfeat:-- changes that add a new featurefix:-- changes that fix existing functionalityrefactor:-- changes that refactor existing functionality without adding any new featuresfeat!:/refactor!:/fix!:-- same as above, but indicates a breaking change. Examples would be changes to the public C API, renaming a board/shield, editing a board or shield to rename devicetree labels that may be used in keymaps, etc.ci:-- changes to our continuous integration setup with GitHub Actions, usually only for the files in.github/workflows/chore:-- grab bag type for small changes that don't fall into any of the above categories, including dependency updates for development tools and docs.
Scopes
The following scopes are frequently used to further clarify the scope of the change:
hid-- changes to our general HID codeusb-- changes specific to USBble-- changes specific to BLEpower-- changes to our power management codesplit-- changes to our split keyboard supportstudio-- changes to our ZMK Studio codedisplay-- changes to to our display codeunderglow-- changes to to our RGB underglow supportbacklight-- changes to to our simple LED backlight supportbehaviors-- changes to to our core behavior codecore-- changes to any other area of our core codeboards-- changes to the in-tree boardsshields-- changes to the in-tree shields